I am going to be a Warrior, and I was hoping if someone could please suggest what profession I should have. Everyone tries the old BS and Mining Combination, but I want to try something new. As a Warrior, I am quite poor, Warriors usually are, so I have given my plan a lot of thought, please comment it...

I need money, so this is my plan to get it with professions.

First I learn Tailoring, as Cloth is one of the most common things dropped, and humanoids are very common, it will be easy to acquire. Secondly It is the most commonly worn thing, Mages, Warlocks and Priest will pay loads for it, AND to top that off, I will also learn Enchanting, the 3 Magic classes will pay tons more if there is an Int or Spi boost, and not only that, but I could enchant anything, even my own Armor which would benefit me.

So could someone please tell me if this is a good idea, and if not, suggest a better one, by the way I will be Alliance, so if you suggest any item requirement skills, please find some that are NOT in the Horde areas. Thanks.

Manufacturing professions as you know, will always be harder to make money off of.  Gathering professions as you know, will be a lot easier to make money off of.

With that said, tailoring may not necessarily be as easy as you think.  Just because cloth drops a lot from various NPC's, it doesn't mean at higher levels, that's all you need for tailoring. 

Check out this list: http://wow.crafterstome.com/recipes/tailoring.html

Once you get to roughly Tailoring 120, you will find that you will need materials from Alchemy and Leatherworking.  Iridescent Pearls drop from clams and other ocean-going creatures and those can be a bitch to farm.  Spider's silk will drive you mad and crazy as they don't drop often.

For enchanting, you can always get shards from disenchanted item BUT once you get to roughly 130, materials can get a lot more complicated and acquiring new recipes can be a lot more difficult too.  Unless you have another toon that makes money for you to level up, it will be hard.

For my first serious toon, I was a herb/alchemist.  I didn't actually start making serious gold until I was level 70 and with my transmutation mastery, sometimes, I made up to 5 Earthstorm Diamonds - imagine that.  Each of those diamonds go for roughly 85 to 95g on my server.  Mind you, I ditched herb and got Jewelcrafting.  So I had two production professions.  Since I was already maxed out in Alchemy, I wasn't going to ditch that for mining which would have helped my JC a lot.  Fortunately, I have friends to help me on mats.

For my second serious toon, I have leatherworking and skinning.  I made a bit of gold for that toon - about 50g every two or three days at level 35.  I started making about 15 to 20g per day at level 20.

For my third serious toon, I have blacksmithing and mining and I'm making about 10g per day.  Mind you, I'm just fooling around and not really serious about making money.

For my fourth serious toon, I have herb and mining just for gathering purposes.

With questing and farming aside, I can make about 400 to 600gg per day or two if I seriously got into it.  If I just fool around, I can make about 50g per day. 

Cool, thanks for the advice.